Add and use interface for replicator #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kickster97
approved these changes
Apr 15, 2024
viktorerlingsson
approved these changes
Apr 15, 2024
|
|
||
| module LavinMQ | ||
| module Replication | ||
| module Replicator |
There was a problem hiding this comment.
Why not an abstract class?
There was a problem hiding this comment.
I like the idea of being able to use multiple interfaces when applicable to reduce the interface you need to mock/stub in specs. Replication::Server now implements Replication::Replicator and Replication::FileIndex.
viktorerlingsson
pushed a commit
that referenced
this pull request
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
Adds interface
ReplicatorwhichReplicator::Serverimplements. This will make it possible to stub/mockReplicator.HOW can this pull request be tested?
Run specs