Fixes for crystal 1.12 #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use macro condition for backward compatibility. Maybe we can use __FILE__ and __LINE__ instead of this?
Method with Number as argument is deprecated
We should get rid of the usage of it.
spuun
force-pushed
the
fixes-for-crystal-1.12
branch
from
8c3b713 to
bf332cd
Compare
kickster97
approved these changes
Apr 15, 2024
viktorerlingsson
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
Fixes deprecation warnings and spec compilation error.
We should probably move away from using
Spec.cli.formatters/Spec.formatters. Maybe use__FILE__and__LINE__instead?HOW can this pull request be tested?
Run spec