Always use x-dead-letter-exchange when deliver a delayed message #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spuun
requested review from
carlhoerberg,
kickster97,
snichme and
viktorerlingsson
as code owners
|
Shouldnt we prevent publishing directly to that internal queue instead? That the default exchange cant route to the queue? |
|
This will cause a performance hit as the headers have to be parsed for each message twice. Not critical for this exchange type, but we should be aware of it. |
|
Yes, this is a "quick fix" and then we need to discuss how to limit internal queues. |
|
Btw, which header parsing are you referring too? |
|
That's much better! |
spuun
added a commit
that referenced
this pull request
Aug 26, 2024
spuun
added a commit
that referenced
this pull request
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
When an exchange is delayed it will create a queue and use message expiration and dead lettering for the delay. When a message is published to the exchange it will put the message in the "delay queue", and when the message is expired it will be republished to the message's exchange and the message is routed.
However, it's possible to publish messages to this queue via the default exchange and then the exchange field of the message is an empty string. This caused the message to be republished to the default exchange instead of the delayed exchange, resulting in the message looping between the queue and default exchange causing lavinmq to freeze.
This PR will make sure that the
x-dead-letter-exchangeargument for the queue is used when the messages is republished due to expiration.HOW can this pull request be tested?
Run specs