-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streams filters #893
Merged
Merged
Streams filters #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktorerlingsson
force-pushed
the
streams-filters
branch
from
January 7, 2025 10:46
4dc6eeb
to
2f08e3a
Compare
spuun
reviewed
Jan 9, 2025
spuun
reviewed
Jan 9, 2025
spuun
reviewed
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments.
edit: lol, i must have hit the wrong button making it multiple reviews... 🤦
spuun
approved these changes
Jan 10, 2025
viktorerlingsson
force-pushed
the
streams-filters
branch
from
January 13, 2025 09:10
8faff93
to
150c2f7
Compare
carlhoerberg
requested changes
Jan 19, 2025
carlhoerberg
approved these changes
Jan 20, 2025
viktorerlingsson
force-pushed
the
streams-filters
branch
from
January 21, 2025 09:57
cb4a6d1
to
76d61b1
Compare
Co-authored-by: Jon Börjesson <[email protected]>
Co-authored-by: Jon Börjesson <[email protected]>
Co-authored-by: Jon Börjesson <[email protected]>
Co-authored-by: Jon Börjesson <[email protected]>
Co-authored-by: Carl Hörberg <[email protected]>
Co-authored-by: Carl Hörberg <[email protected]>
Co-authored-by: Carl Hörberg <[email protected]>
Co-authored-by: Carl Hörberg <[email protected]>
Co-authored-by: Carl Hörberg <[email protected]>
viktorerlingsson
force-pushed
the
streams-filters
branch
from
January 23, 2025 10:50
d0f101b
to
6bb2ae1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
Adds support for filtering in streams.
Filters can be set on messages by providing
x-stream-filter-value
when publishing messages to a stream.When a consumer tries to consume with
x-stream-filter
set, only messages matching the filter value will be returned.x-stream-filter
on consumers can be a single value as a string, or a set of values separated by commas. Any message matching any of the filters on the consumer will be returned.You can also choose to return all messages without a filter by providing
x-stream-match-unfiltered
as an argument on the consumer.If you do not provide
x-stream-filter
when consuming, all messages in the stream will be returned as if no filters existed.HOW can this pull request be tested?
Run specs