Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove Rlimit alias and struct that was added in crystal 1.15 #905

Merged
merged 2 commits into from
Jan 10, 2025
Merged

remove Rlimit alias and struct that was added in crystal 1.15 #905

merged 2 commits into from
Jan 10, 2025

Conversation

viktorerlingsson
Copy link
Member

@viktorerlingsson viktorerlingsson commented Jan 10, 2025 •
edited
Loading

WHAT is this pull request doing?

Rlimt alias, Rlimit struct and fun getrlimit was added to Crystal in 1.15 (for example here), so we don't have to do that ourselves.

Also make sure we run brew update before brew install to make sure we get the latest versions in CI.

HOW can this pull request be tested?

Run specs

@viktorerlingsson viktorerlingsson requested a review from a team as a code owner January 10, 2025 14:16
@viktorerlingsson viktorerlingsson merged commit 6c19353 into main Jan 10, 2025
24 of 25 checks passed
@viktorerlingsson viktorerlingsson deleted the crystal-1_15 branch January 10, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spuun spuun spuun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viktorerlingsson @spuun