Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add trailing commas where appropriate for 'that is' in CESQL spec #1292

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

Cali0707
Copy link
Contributor

@Cali0707 Cali0707 commented Jun 6, 2024

Addresses #1282 (comment)

Proposed Changes

  • Add trailing commas where appropriate after "that is" in the spec (I audited all of them and only found the two mentioned in the original comment as being wrong

@Cali0707
Copy link
Contributor Author

Cali0707 commented Jun 6, 2024

cc @markpeek @duglin

@markpeek markpeek self-requested a review June 6, 2024 18:07
Copy link
Contributor

@markpeek markpeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@duglin
Copy link
Collaborator

duglin commented Jun 6, 2024

@Cali0707 LGTM however, can you use this PR to wrap the spec at 80 columns? I just remember that it was the last outstanding change from the other PR. I think we've used: https://prettier.io/ in the past, if that helps

@duglin
Copy link
Collaborator

duglin commented Jun 7, 2024

@Cali0707 thanks!
Approved on the 7/6 call... merging

@duglin duglin merged commit c28210f into cloudevents:main Jun 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants