fix: CESQL conformance tests are correct with spec v1 #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove IS_(BOOL|INT|STRING) tests since the functions are not required by spec * Fix cast of boolean no longer causing error * Remove test that requires complete expression evaluation, as the spec leaves this to implementations * Fix remaining tests to return missing attribute errors where necessary Signed-off-by: Calum Murray <[email protected]>
Cali0707
changed the title
|
LGTM |
|
Approved on the 6/13 call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing the v1 spec changes in the go sdk, I found that there were some inconsistencies with the conformance tests and the v1 spec. This PR fixes the conformance tests
Proposed Changes
IS_(BOOL|INT|STRING)tests since the functions are not required by spec