Introduce InstancesState in the AppWorkload resrouce status #3781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgethebeatle
force-pushed
the
issues/3755-app-workload-state
branch
from
9d64dc8 to
a992171
Compare
Today korifi looks directly at the pods running on the cluster, but once the user provides a custom appworkload controller, this does not work anymore, as it breaches the abstraction. Korifi should not rely on any concrete implementation below the AppWorkload interface resource. Co-authored-by: Georgi Sabev <[email protected]>
danail-branekov
force-pushed
the
issues/3755-app-workload-state
branch
from
a491f7a to
005ffb9
Compare
danail-branekov
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#3755
What is this change about?
Today korifi looks directly at the pods running on the cluster, but once
the user provides a custom appworkload controller, this does not work
anymore, as it breaches the abstraction. Korifi should not rely on any
concorete implementation below the AppWorkload interface resource
To fix this we have introduced a new InstancesState field in the AppWorkload resource status.