RD-3099 Fix uploading blueprint that contains directories recognized as files by decompress library
#1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubama
reviewed
Sep 14, 2021
| @@ -22,4 +23,18 @@ describe('ArchiveHelper', () => { | |||
| ) | |||
| ); | |||
| }); | |||
|
|
|||
| it('extracts specified archive to target directory', () => { | |||
| const srcArchiveName = 'bangchak-poc'; | |||
There was a problem hiding this comment.
Does this archive name has any particular meaning? How about naming it in a way so that it points to the test that is using it?
There was a problem hiding this comment.
No, I just reused the one attached to the issue.
Do you mean having e.g. ArchiveHelper.zip? Once you confirm, I'll update it.
There was a problem hiding this comment.
Changed archive name. I didn't manage to change the content of the archive.
As when I tried unzipping and zipping again I couldn't reproduce the original issue without filter set, so I decided to leave the content of the archive unchanged.
kubama
approved these changes
Sep 15, 2021
qooban
added a commit
that referenced
this pull request
Sep 15, 2021
…as files by `decompress` library (#1603)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change applies workaround for a bug in
decompresslibrary (kevva/decompress#46 (comment)).Screenshots / Videos
N/A
Checklist
Tests
Stage-UI-System-Test/1265 (14.09.2021 15:00:00 CEST)
Documentation
N/A