Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide constructors of utility classes #176

Closed
vil02 opened this issue Oct 7, 2024 · 0 comments · Fixed by #177
Closed

Hide constructors of utility classes #176

vil02 opened this issue Oct 7, 2024 · 0 comments · Fixed by #177
Assignees

Comments

@vil02
Copy link
Contributor

vil02 commented Oct 7, 2024

Describe the bug in a sentence or two.

These classes:

could be proper utilities (i.e. marked as final with private default constructor). Such change makes it harder to misuse them (prevents instantiation and inheritance) and makes the coverage reports more accurate.

Issue Type (Can be multiple)

[ ] Build - Can’t install or import the SDK
[ ] Performance - Performance issues
[ ] Behaviour - Functions aren’t working as expected (Such as generate URL)
[ ] Documentation - Inconsistency between the docs and behaviour
[x] Other (Specify) - code quality

Related to #173.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants