Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: make utility classes proper utilities #177

Merged
merged 2 commits into from
Oct 20, 2024
Merged

style: make utility classes proper utilities #177

merged 2 commits into from
Oct 20, 2024

Conversation

vil02
Copy link
Contributor

@vil02 vil02 commented Oct 7, 2024 •
edited
Loading

Brief Summary of Changes

Changed classes are marked as final and their default constructor as private.

What does this PR address?

Are tests included?

  • Yes
  • No

Reviewer, please note:

Fixes #176.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I ran the full test suite before pushing the changes and all the tests pass.

@vil02 vil02 marked this pull request as ready for review October 7, 2024 16:47
@adimiz1
Copy link
Contributor

adimiz1 commented Oct 20, 2024

Hi @vil02
Thank you very much for submitting this PR
It seems the branch is conflicting with the current master, can you please fix and push again?

@vil02
Copy link
Contributor Author

vil02 commented Oct 20, 2024

@adimiz1: I resolved the conflict. Please have a look.

@adimiz1 adimiz1 merged commit bb34804 into cloudinary:master Oct 20, 2024
1 check passed
@vil02 vil02 deleted the 176_make_utils_proper_utils branch October 20, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adimiz1 adimiz1 adimiz1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide constructors of utility classes
2 participants
@vil02 @adimiz1