Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prompt], [fzf] Slightly better support for Unicode-challenged terminals #429

Merged
merged 5 commits into from
Apr 1, 2019

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Apr 1, 2019

what

  • Add option to set GEODISIC_PROMPT_GLYPHS to set (or remove) glyphs at end of command line prompt
  • Set fzf to use plain ASCII when PROMPT_STYLE is set to plain.

why

Partly address issues such as #417

@Nuru Nuru requested a review from osterman April 1, 2019 02:08
osterman
osterman previously approved these changes Apr 1, 2019
@Nuru
Copy link
Contributor Author

Nuru commented Apr 1, 2019

@osterman Are you going to fix the lint problem?

@Nuru
Copy link
Contributor Author

Nuru commented Apr 1, 2019

@osterman .travis.yaml explicitly calls make bash/fmt/check, so there is no need for make lint to try to do that as well, so I just took it out. I think the bash/fmt recipes should reference $(CURDIR) rather than $(PWD) but I'm not sure enough about how the whole build system works to make the change right now.

@Nuru Nuru requested a review from osterman April 1, 2019 06:38
@Nuru Nuru merged commit 258ca72 into master Apr 1, 2019
@Nuru Nuru deleted the prompt branch April 1, 2019 08:35
leb4r pushed a commit that referenced this pull request Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants