Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use and expose api url env variable #159

Merged
merged 3 commits into from
Nov 10, 2023
Merged

feat: Use and expose api url env variable #159

merged 3 commits into from
Nov 10, 2023

Conversation

disq
Copy link
Member

@disq disq commented Nov 8, 2023 •
edited
Loading

Use CLOUDQUERY_API_URL for everything. Other consumers can now also use managedplugin.APIBaseURL()

Breaking compatibility very briefly (string becomes a func for a cq-internal functionality) so I'm not doing a feat!

@disq disq requested a review from hermanschaaf November 8, 2023 16:51
@disq disq requested a review from yevgenypats as a code owner November 8, 2023 16:51
@github-actions github-actions bot added the feat label Nov 8, 2023
@github-actions github-actions bot added feat and removed feat labels Nov 8, 2023
@disq disq added the automerge Add to automerge PRs once requirements are met label Nov 10, 2023
@kodiakhq kodiakhq bot merged commit ec64db6 into main Nov 10, 2023
@kodiakhq kodiakhq bot deleted the feat/use-api-url-env branch November 10, 2023 16:48
@cq-bot cq-bot mentioned this pull request Nov 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hermanschaaf hermanschaaf hermanschaaf approved these changes

@yevgenypats yevgenypats Awaiting requested review from yevgenypats

Assignees
No one assigned
Labels
automerge Add to automerge PRs once requirements are met feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@disq @hermanschaaf