Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Update aws to v23.3.1 #264

Merged
merged 55 commits into from
Dec 28, 2023

Conversation

candiduslynx
Copy link
Contributor

@candiduslynx candiduslynx requested a review from a team as a code owner November 21, 2023 15:23
@candiduslynx candiduslynx requested review from bbernays, disq, john-s58, jsonpr and ronsh12 and removed request for a team November 21, 2023 15:23
@candiduslynx candiduslynx force-pushed the fix/aws_cloudtrail_trail_event_selectors/v23-schema branch 2 times, most recently from 0ca3bd0 to 0d5539f Compare November 22, 2023 07:36
@jsonpr
Copy link
Contributor

jsonpr commented Nov 28, 2023

Macro is now here: https://github.com/cloudquery/policies-premium/blob/main/transformations/aws/macros/cloudtrail/enabled_in_all_regions.sql

@candiduslynx candiduslynx force-pushed the fix/aws_cloudtrail_trail_event_selectors/v23-schema branch from 0d5539f to 19300c1 Compare November 29, 2023 08:46
@candiduslynx candiduslynx force-pushed the fix/aws_cloudtrail_trail_event_selectors/v23-schema branch from 19300c1 to 221f04d Compare December 4, 2023 11:21
@candiduslynx candiduslynx requested a review from jsonpr December 4, 2023 11:22
@candiduslynx
Copy link
Contributor Author

@jsonpr could you tak a look once again per the updated location?

@candiduslynx candiduslynx self-assigned this Dec 4, 2023
@bbernays bbernays added automerge Automatically merge once required checks pass and removed no automerge Block automatic merging labels Dec 28, 2023
@kodiakhq kodiakhq bot merged commit d361f9b into main Dec 28, 2023
14 checks passed
@kodiakhq kodiakhq bot deleted the fix/aws_cloudtrail_trail_event_selectors/v23-schema branch December 28, 2023 17:01
kodiakhq bot pushed a commit that referenced this pull request Jan 17, 2024
…435)

🤖 I have created a release *beep* *boop*
---


## [2.0.0](transformation-aws-asset-inventory-free-v1.1.1...transformation-aws-asset-inventory-free-v2.0.0) (2024-01-17)


### ⚠ BREAKING CHANGES

* Update `aws` to `v23.3.1` ([#264](#264))

### Features

* Update `aws` to `v23.3.1` ([#264](#264)) ([d361f9b](d361f9b))


### Bug Fixes

* **deps:** Update dependency dbt-postgres to v1.7.4 ([#473](#473)) ([a7f759a](a7f759a))
* Link to latest versions in README ([#428](#428)) ([44901a2](44901a2))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot pushed a commit that referenced this pull request Jan 18, 2024
🤖 I have created a release *beep* *boop*
---


## [2.0.0](visualization-aws-compliance-v1.3.0...visualization-aws-compliance-v2.0.0) (2024-01-17)


### ⚠ BREAKING CHANGES

* Update `aws` to `v23.3.1` ([#264](#264))

### Features

* Trigger GCP Free Build Transformations ([5c68bae](5c68bae))
* Trigger GCP Free Build Transformations ([#385](#385)) ([5c68bae](5c68bae))
* Update `aws` to `v23.3.1` ([#264](#264)) ([d361f9b](d361f9b))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot pushed a commit that referenced this pull request Jan 18, 2024
🤖 I have created a release *beep* *boop*
---


## [2.0.0](visualization-aws-asset-inventory-v1.0.0...visualization-aws-asset-inventory-v2.0.0) (2024-01-18)


### ⚠ BREAKING CHANGES

* Update `aws` to `v23.3.1` ([#264](#264))

### Features

* Trigger GCP Free Build Transformations ([5c68bae](5c68bae))
* Trigger GCP Free Build Transformations ([#385](#385)) ([5c68bae](5c68bae))
* Update `aws` to `v23.3.1` ([#264](#264)) ([d361f9b](d361f9b))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot pushed a commit that referenced this pull request Jan 22, 2024
🤖 I have created a release *beep* *boop*
---


## [2.0.0](visualization-aws-data-resilience-v1.1.0...visualization-aws-data-resilience-v2.0.0) (2024-01-22)


### ⚠ BREAKING CHANGES

* Update `aws` to `v23.3.1` ([#264](#264))

### Features

* Trigger GCP Free Build Transformations ([5c68bae](5c68bae))
* Trigger GCP Free Build Transformations ([#385](#385)) ([5c68bae](5c68bae))
* Update `aws` to `v23.3.1` ([#264](#264)) ([d361f9b](d361f9b))


### Bug Fixes

* Some graphs were querying the wrong view ([#510](#510)) ([3fbfe31](3fbfe31))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot pushed a commit to cloudquery/cloudquery that referenced this pull request Feb 9, 2024
Follow-up for cloudquery/policies#264

ARNs are constructed based on https://docs.aws.amazon.com/service-authorization/latest/reference/list_amazonguardduty.html#amazonguardduty-resources-for-iam-policies

Based on the [`CreateDetector` API documentation](https://docs.aws.amazon.com/guardduty/latest/APIReference/API_CreateDetector.html) we don't need to use `request_account_id` & `request_region` columns, but rather their plain variants (`account_id` & `region` respectively).
The only issue is `aws_guardduty_detector_members` table, where `account_id` is a part of the resource itself. It's solved by renaming the resource `account_id` column to `member_account_id`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge once required checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants