fix: Prevent Table from crashing when removing a column in edit state (…

…#3222)
cloudscape-design · Jan 28, 2025 · 7f23985 · 7f23985
1 parent 34cd820
commit 7f23985
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/table/__tests__/body-cell.test.tsx b/src/table/__tests__/body-cell.test.tsx
@@ -169,6 +169,15 @@ describe('TableBodyCell', () => {
     expect(stickyCellRef).toHaveBeenCalledWith(null);
   });
 
+  it('should not throw an error if column is not editable', () => {
+    const col: typeof column = {
+      id: 'test',
+      header: 'Test',
+      cell: item => item.test,
+    };
+    render(<TestComponent column={col} isEditing={true} />);
+  });
+
   describe('success icon behaviour', () => {
     const bodyCellSuccessIcon$ = `.${styles['body-cell-success']}`;
 

diff --git a/src/table/body-cell/index.tsx b/src/table/body-cell/index.tsx
@@ -85,7 +85,7 @@ function TableCellEditable<ItemType>({
       onMouseEnter={() => setHasHover(true)}
       onMouseLeave={() => setHasHover(false)}
     >
-      {isEditing ? (
+      {isEditing && column.editConfig ? (
         <InlineEditor
           ariaLabels={ariaLabels}
           column={column}