feat: Duplicate - Blue dialog contribution #2946
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cansuaa
force-pushed
the
cansua/blue-dialog-contribution
branch
from
277560b to
793d280
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2946 +/- ##
=======================================
Coverage 96.45% 96.45%
=======================================
Files 791 791
Lines 22314 22314
Branches 7601 7670 +69
=======================================
Hits 21523 21523
Misses 739 739
Partials 52 52 ☔ View full report in Codecov by Sentry. |
pan-kot
reviewed
Jan 28, 2025
| const dialogRef = useRef<HTMLDivElement>(null); | ||
| const triggerRef = useRef<HTMLElement | null>(null); | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
I think it is better to manage the focus transition outside of this component. For instance, you can forward the ref to the dialog's root so that it will be possible to do dialogRef.focus() from the outside code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.