feat: Public layout component #3208
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3208 +/- ##
========================================
Coverage 96.44% 96.44%
========================================
Files 791 793 +2
Lines 22563 22621 +58
Branches 7728 7828 +100
========================================
+ Hits 21760 21817 +57
- Misses 750 751 +1
Partials 53 53 ☔ View full report in Codecov by Sentry. |
georgylobko
commented
Jan 21, 2025
There was a problem hiding this comment.
These styles were copied from pages/app-layout
…mponent # Conflicts: # src/__tests__/snapshot-tests/__snapshots__/test-utils-wrappers.test.tsx.snap
…vided nor at least one drawer with trigger
…den, added configs to page layout demo
georgylobko
commented
Feb 5, 2025
| if (props.navigationTriggerHide) { | ||
| toolbar.hasNavigation = false; | ||
| } | ||
| const splitPanelTriggerHide = (props?.splitPanel as React.ReactElement)?.props?.closeBehavior === 'hide'; |
There was a problem hiding this comment.
not sure about this line. here we basically read a prop from the split panel component. feel free to suggest better alternatives
georgylobko
commented
Feb 5, 2025
| } | ||
|
|
||
| if (!isVisualRefresh) { | ||
| warnOnce( |
There was a problem hiding this comment.
should we throw an error instead, or completely prevent the component from rendering?
georgylobko
requested review from
gethinwebster and
just-boris
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
doc: tb1MA6m8ZZEt
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.