fix: Reannounce validation error in date range picker on apply #3210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3210 +/- ##
=======================================
Coverage 96.44% 96.44%
=======================================
Files 791 791
Lines 22561 22563 +2
Branches 7796 7728 -68
=======================================
+ Hits 21758 21760 +2
Misses 750 750
Partials 53 53 ☔ View full report in Codecov by Sentry. |
abdhalees
requested review from
at-susie,
a team and
jperals
and removed request for
a team and
at-susie
|
Could we have integ coverage for this? |
jperals
reviewed
Jan 23, 2025
abdhalees
force-pushed
the
data-range-picker-error-reannounce
branch
from
e7f109c to
d4cbeac
Compare
abdhalees
force-pushed
the
data-range-picker-error-reannounce
branch
from
d4cbeac to
7861fba
Compare
@jperals added a unit test |
jperals
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a user clicks on "Apply" in DateRangePicker, the error text should be reannounced
Related links, issue #, if available: AWSUI-60295
How has this been tested?
with voice over on, following the recording in the ticket
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.