Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "feat: Add flexible layout for attribute editor (#3123)" #3211

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

gethinwebster
Copy link
Member

This reverts commit 28012d5.

Description

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@gethinwebster gethinwebster requested a review from a team as a code owner January 22, 2025 07:15
@gethinwebster gethinwebster requested review from cansuaa and removed request for a team January 22, 2025 07:15
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.42%. Comparing base (0830379) to head (f3a9b23).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3211      +/-   ##
==========================================
- Coverage   96.42%   96.42%   -0.01%     
==========================================
  Files         789      787       -2     
  Lines       22251    22191      -60     
  Branches     7231     7209      -22     
==========================================
- Hits        21456    21398      -58     
+ Misses        788      786       -2     
  Partials        7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gethinwebster gethinwebster added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit 372abbd Jan 22, 2025
38 checks passed
@gethinwebster gethinwebster deleted the revert-atted branch January 22, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants