Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add flexible layout for attribute editor #3212

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

gethinwebster
Copy link
Member

Description

Re-run of #3123 with an additional fix for a regression found in visual tests (missing individual row labels in certain layouts)

Related links, issue #, if available: n/a

How has this been tested?

Tested locally

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 98.92473% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.42%. Comparing base (372abbd) to head (d4d198f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/attribute-editor/utils.ts 96.87% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3212   +/-   ##
=======================================
  Coverage   96.42%   96.42%           
=======================================
  Files         787      789    +2     
  Lines       22191    22251   +60     
  Branches     7555     7577   +22     
=======================================
+ Hits        21398    21456   +58     
- Misses        741      743    +2     
  Partials       52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gethinwebster gethinwebster added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit 1d18d63 Jan 23, 2025
38 checks passed
@gethinwebster gethinwebster deleted the attribute-editor-fix branch January 23, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants