Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Increases the chart legend horizontal gap #3214

Merged

Conversation

orangevolon
Copy link
Contributor

Description

  • Adds vertical gap between the legend markers when wrapped.
  • Replaces the margin-right with gap property.

Related links, issue #, if available: AWSUI-60251

How has this been tested?

  • Dev pipeline visual tests
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.45%. Comparing base (baad5f7) to head (c1b3534).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3214    +/-   ##
========================================
  Coverage   96.45%   96.45%            
========================================
  Files         791      791            
  Lines       22314    22314            
  Branches     7661     7255   -406     
========================================
  Hits        21523    21523            
  Misses        784      784            
  Partials        7        7            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orangevolon orangevolon marked this pull request as ready for review January 27, 2025 09:39
@orangevolon orangevolon requested a review from a team as a code owner January 27, 2025 09:39
@orangevolon orangevolon requested review from georgylobko and removed request for a team January 27, 2025 09:39
@orangevolon orangevolon added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit 6f86b52 Jan 28, 2025
38 checks passed
@orangevolon orangevolon deleted the alamiami/fixes-insufficient-target-size-for-chart-legends branch January 28, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants