Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: Revert "feat: Add bottom border to top navigation (#3192)" #3216

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

cansuaa
Copy link
Contributor

@cansuaa cansuaa commented Jan 24, 2025

This reverts commit 13ff9d4.

Description

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cansuaa cansuaa changed the title Revert "feat: Add bottom border to top navigation (#3192)" revert: Revert "feat: Add bottom border to top navigation (#3192)" Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (e1c488b) to head (c06bff8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3216    +/-   ##
========================================
  Coverage   96.44%   96.44%            
========================================
  Files         790      790            
  Lines       22246    22246            
  Branches     7644     7229   -415     
========================================
  Hits        21455    21455            
- Misses        739      784    +45     
+ Partials       52        7    -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cansuaa cansuaa marked this pull request as ready for review January 24, 2025 14:04
@cansuaa cansuaa requested a review from a team as a code owner January 24, 2025 14:04
@cansuaa cansuaa requested review from jperals and timogasda and removed request for a team and jperals January 24, 2025 14:04
@cansuaa cansuaa added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit c357e20 Jan 24, 2025
38 of 39 checks passed
@cansuaa cansuaa deleted the cansua/top-navigation-bottom-border branch January 24, 2025 14:34
@purplepenguin2
Copy link

Was there any info on why this was reverted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants