fix: Allow hover tooltips to be dismissed using Esc #3217
+332
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avinashbot
force-pushed
the
tooltip-a11y
branch
from
b0eb3ac to
aa34e19
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3217 +/- ##
==========================================
- Coverage 96.45% 96.42% -0.04%
==========================================
Files 791 791
Lines 22315 22343 +28
Branches 7667 7662 -5
==========================================
+ Hits 21524 21544 +20
- Misses 739 746 +7
- Partials 52 53 +1 ☔ View full report in Codecov by Sentry. |
avinashbot
force-pushed
the
tooltip-a11y
branch
from
aa34e19 to
b237085
Compare
avinashbot
commented
Jan 29, 2025
| }: TooltipProps) { | ||
| if (!trackKey && (typeof value === 'string' || typeof value === 'number')) { | ||
| trackKey = value; | ||
| } | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
This is the new addition! The rest is just basically scaffolding.
avinashbot
commented
Jan 29, 2025
| @@ -61,6 +61,9 @@ const Item = ( | |||
|
|
|||
| const { descriptionEl, descriptionId } = useHiddenDescription(disabledReason); | |||
|
|
|||
| const [canShowTooltip, setCanShowTooltip] = useState(true); | |||
| useEffect(() => setCanShowTooltip(true), [highlighted]); | |||
There was a problem hiding this comment.
Doing this to reset the canShowTooltip state when highlight moves to another item.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Does what it says on the tin - tooltips should be dismissible by hitting the Escape key. I know the visibility logic for the tooltips is handled outside them, but it still seemed sensible to put the dismiss handler inside the tooltip in one shared place.
Not as complicated as it looks! A lot of it is just unit testing or just implementing the new
onDismisshandler, which is super simple. Check my comments to see the areas of interest first.Related links, issue #, if available: AWSUI-60227, AWSUI-60225, AWSUI-60230, AWSUI-60226, AWSUI-60228, AWSUI-60231, AWSUI-60229
How has this been tested?
Added a unit test to the tooltip component itself, and all other components that use it.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.