Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sass incompatible units #3221

Closed
wants to merge 1 commit into from
Closed

Conversation

georgylobko
Copy link
Contributor

Description

Some packages in the build 7206966688 have failed because of the units incompatibility problem as shown below:

SassError: 1 and 0.25em are incompatible.

1136 │ line-height: calc(1 + 0.25em + var(--border-divider-list-width-471u6a, 1px));
│ ^^^^^^^^^^

While this code works correctly in most packages, it fails in some packages, likely due to their Webpack configuration. To avoid this issue, wrap the problematic styles with string.unquote, which should resolve the problem.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (c357e20) to head (92abd47).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3221   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files         790      790           
  Lines       22246    22249    +3     
  Branches     7575     7637   +62     
=======================================
+ Hits        21455    21458    +3     
  Misses        739      739           
  Partials       52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgylobko georgylobko marked this pull request as ready for review January 27, 2025 11:50
@georgylobko georgylobko requested a review from a team as a code owner January 27, 2025 11:50
@georgylobko georgylobko requested review from YueyingLu and removed request for a team January 27, 2025 11:50
@georgylobko georgylobko deleted the fix/sass-incompatible-units branch January 27, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants