fix: Incorporate split panel height when rendering stickyVerticalBottomOffset value #3225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just-boris
commented
Jan 27, 2025
|
|
||
| import mobileStyles from '../../../lib/components/app-layout/mobile-toolbar/styles.selectors.js'; | ||
| import tableScrollbarStyles from '../../../lib/components/table/sticky-scrollbar/styles.selectors.js'; | ||
|
|
||
| const scrollbarSelector = `.${tableScrollbarStyles['sticky-scrollbar-visible']}`; |
There was a problem hiding this comment.
That's how we access this element in other integration tests:
Comment on lines
-22
to
+25
| const params = new URLSearchParams({ | ||
| visualRefresh: `${theme.startsWith('refresh')}`, | ||
| appLayoutToolbar: `${theme === 'refresh-toolbar'}`, | ||
| }); | ||
| await browser.url(`${url}?${params.toString()}`); | ||
| await browser.url(`${url}?${getUrlParams(theme)}`); |
There was a problem hiding this comment.
Removed custom code while we are here
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3225 +/- ##
=======================================
Coverage 96.45% 96.45%
=======================================
Files 791 791
Lines 22314 22315 +1
Branches 7661 7659 -2
=======================================
+ Hits 21523 21524 +1
+ Misses 784 739 -45
- Partials 7 52 +45 ☔ View full report in Codecov by Sentry. |
just-boris
force-pushed
the
sticky-scrollbar-offset
branch
from
d82e217 to
383e072
Compare
pan-kot
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing a bug
Related links, issue #, if available: AWSUI-60293
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.