Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding new i18n strings for date-range-picker in preparation for month granularity #3228

Closed
wants to merge 1 commit into from

Conversation

dpitcock
Copy link
Member

Adding new i18n strings to the date-range picker in preparation for month granularity

  • New strings and english message submitted in CR-173719099, CR-165479809
  • Translations completed
  • result has been build, copied and and committed to this package

Related links, issue #, if available: n/a

How has this been tested?

all tests ran to confirm no failures, especially confirming no updates to snapshots have been applied

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dpitcock dpitcock requested a review from a team as a code owner January 28, 2025 11:21
@dpitcock dpitcock requested review from taheramr and removed request for a team January 28, 2025 11:21
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.45%. Comparing base (708ecb7) to head (69ac6d0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3228   +/-   ##
=======================================
  Coverage   96.45%   96.45%           
=======================================
  Files         791      791           
  Lines       22315    22315           
  Branches     7667     7659    -8     
=======================================
  Hits        21524    21524           
  Misses        739      739           
  Partials       52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpitcock dpitcock marked this pull request as draft January 28, 2025 13:13
@dpitcock
Copy link
Member Author

No longer necessary as a merge conflict is demanding another revision to the PR, so including the changes there

@dpitcock dpitcock closed this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant