fix: Live announce resultState in ProgressBar #3229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3229 +/- ##
=======================================
Coverage 96.45% 96.45%
=======================================
Files 790 790
Lines 22299 22299
Branches 7664 7595 -69
=======================================
Hits 21508 21508
Misses 739 739
Partials 52 52 ☔ View full report in Codecov by Sentry. |
johannes-weber
changed the title
johannes-weber
force-pushed
the
a11y-add-live-region-to-progress-bar
branch
2 times, most recently
from
0538f0f to
2facfb8
Compare
johannes-weber
commented
Jan 29, 2025
| @@ -253,8 +261,10 @@ describe('Progress updates', () => { | |||
| expect(wrapper.find(`.${liveRegionStyles.root}`)?.getElement().textContent).toBe(`${label}: 0%`); | |||
| rerender(<ProgressBar label={label} value={2} />); | |||
|
|
|||
| // 6 seconds passed, live region has a new value | |||
| jest.advanceTimersByTime(6000); | |||
| act(() => { | |||
There was a problem hiding this comment.
Wrapped with an act because state updates are happening (https://github.com/cloudscape-design/components/blob/main/src/progress-bar/index.tsx#L55) when running the timers. This removes the related act warning when running the tests.
johannes-weber
requested review from
avinashbot
and removed request for
a team
johannes-weber
force-pushed
the
a11y-add-live-region-to-progress-bar
branch
from
2facfb8 to
7ea6ad9
Compare
avinashbot
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this change, the
resultStatewas not live-announced when displayed becaue the content of thearia-livecontainer did not change.With this change, the
InternalLiveRegioncomponnt takes care about the live announcement, once theresultStateis rendered.Related links, issue #, if available: AWSUI-60207
How has this been tested?
with-updatesdemo page, enable VO and click the "Start" button. Live announcement is happening once the loading is done.Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.