fix:change the parameter service to server_name #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
li-jin-gou
reviewed
May 29, 2024
cmd/static/server_flags.go
Outdated
| @@ -26,6 +26,7 @@ func serverFlags() []cli.Flag { | |||
| globalArgs := config.GetGlobalArgs() | |||
| return []cli.Flag{ | |||
| &cli.StringFlag{Name: consts.Service, Usage: "Specify the service name.", Destination: &globalArgs.ServerArgument.Service}, | |||
li-jin-gou
reviewed
May 29, 2024
li-jin-gou
reviewed
May 29, 2024
li-jin-gou
reviewed
May 29, 2024
pkg/client/check.go
Outdated
| @@ -41,8 +41,8 @@ func check(ca *config.ClientArgument) error { | |||
| return errors.New("unsupported registry") | |||
| } | |||
|
|
|||
| if ca.Service == "" { | |||
| return errors.New("must specify service name when use registry") | |||
| if ca.Service == "" && ca.ServerName == "" { | |||
|
修改了两参数指向同一个变量（server_name） |
li-jin-gou
reviewed
May 30, 2024
cmd/static/client_flags.go
Outdated
| @@ -25,7 +25,8 @@ import ( | |||
| func clientFlags() []cli.Flag { | |||
| globalArgs := config.GetGlobalArgs() | |||
| return []cli.Flag{ | |||
| &cli.StringFlag{Name: consts.Service, Usage: "Specify the service name.", Destination: &globalArgs.ClientArgument.Service}, | |||
| &cli.StringFlag{Name: consts.Service, Usage: "Specify the server name.(Not recommended)", Destination: &globalArgs.ClientArgument.ServerName}, | |||
li-jin-gou
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
What this PR does / why we need it (en: English/zh: Chinese):
en: Change the parameter service to server_name.The service parameter name is not easily understood by the user.
zh: 修复service参数名称为server_name,service参数名称不容易被用户理解。
Which issue(s) this PR fixes: