Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update opentelemetry example #83

Merged
merged 2 commits into from
Nov 23, 2023
Merged

chore: update opentelemetry example #83

merged 2 commits into from
Nov 23, 2023

Conversation

GuangmingLuo
Copy link
Member

@GuangmingLuo GuangmingLuo commented Nov 23, 2023 •
edited
Loading

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: add some log and comments for opentelemetry example
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@GuangmingLuo GuangmingLuo requested review from a team as code owners November 23, 2023 06:48
CoderPoet
CoderPoet reviewed Nov 23, 2023
View reviewed changes
opentelemetry/client/main.go Outdated Show resolved Hide resolved
opentelemetry/client/main.go Outdated Show resolved Hide resolved
CoderPoet
CoderPoet approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@CoderPoet CoderPoet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@GuangmingLuo GuangmingLuo merged commit 33e21bc into main Nov 23, 2023
4 checks passed
@GuangmingLuo GuangmingLuo deleted the opentelemetry branch November 23, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoderPoet CoderPoet CoderPoet approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuangmingLuo @CoderPoet