feat: also handle stream error message in ffgets

CHANGELOG.md

@@ -9,8 +9,8 @@
 
 ### Changed
 
-- Stream reading errors are silenced in parseObjects, an exception that contains
-  the error message is still thrown.
+- Stream reading errors in `parseObjects()` and `parseHeader()` are silenced,
+  an exception is still thrown but it now contains the error message.
 
 ### Removed
 

src/SphinxInventoryParser.php

@@ -253,8 +253,11 @@ protected function parseObjectsV2(string $baseURI): Generator {
  */
 function ffgets($stream, ?int $length = null): string
 {
-	$line = is_null($length) ? fgets($stream) : fgets($stream, $length);
+	$line = is_null($length) ? @fgets($stream) : @fgets($stream, $length);
 	if ($line === false) {
+		if (!feof($stream)) {
+			throw new UnexpectedValueException('could not read line: ' . error_msg());
+		}
 		throw new UnexpectedValueException('unexpected end of file');
 	}
 	return $line;

tests/SphinxInventoryParserTest.php

@@ -253,6 +253,16 @@ public function testParseHeaderEmptyProject(): void
 		fclose($stream);
 	}
 
+	public function testParseHeaderStreamError(): void
+	{
+		$this->expectException(UnexpectedValueException::class);
+		$this->expectExceptionMessage("could not read line: fgets():");
+		$stream = fopen(__DIR__ . "/data/valid.header", 'a');
+		$parser = new SphinxInventoryParser($stream);
+		$parser->parseHeader();
+		fclose($stream);
+	}
+
 	public function testParseFromDocException(): void
 	{
 		$this->expectException(RuntimeException::class);