Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move away from deprecated pkg_resources #210

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

eguiraud
Copy link
Contributor

@eguiraud eguiraud commented Oct 9, 2023

I followed the migration guide:
https://importlib-resources.readthedocs.io/en/latest/migration.html.

Unfortunately the new APIs are only available as of Python 3.9. There are other ones, also in importlib.resources, that are available since 3.7 but are deprecated and 3.11.

As a rationale for the migration, see #211.

I followed the migration guide:
https://importlib-resources.readthedocs.io/en/latest/migration.html.

Unfortunately the new APIs are only available as of Python 3.9.
There are other ones, also in `importlib.resources`, that are
available since 3.7 but are deprecated and 3.11.
@nsmith- nsmith- marked this pull request as ready for review February 2, 2024 20:21
Copy link
Collaborator

@nsmith- nsmith- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-approving :)
This is apparently necessary for python 3.12 support

@nsmith- nsmith- merged commit 9b96ada into cms-nanoAOD:master Feb 2, 2024
8 checks passed
@nsmith- nsmith- linked an issue Feb 28, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Migrate away from deprecated pkg_resources
2 participants