-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link against libz and pthread privately #258
Conversation
@lmoureaux sorry this fell off my radar. Take a look |
No worries, we're all very busy :) This is the error I was reporting and one of the proposed solutions, so I'm happy! I'm wondering if this could be used as a basic test of the C++ interface. It seems there is currently none? |
There is only a test through the PyROOT binding at the moment: correctionlib/tests/test_binding.py Lines 32 to 36 in 87d0a14
but yes it would be good to verify the static compilation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
There is some issue with compiling and running this test example that I cannot debug as I don't have a windows machine. Calling it good enough without. |
Fixes #235
Tested by creating
CMakeLists.txt
:and
test.cc
:and confirming
cmake $(correction config --cmake) . && make
completed successfully. Without this patch, I get the error