Added search/filter results for blog posts #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Abraham <[email protected]>
Signed-off-by: Chris Abraham <[email protected]>
Signed-off-by: Chris Abraham <[email protected]>
Signed-off-by: Chris Abraham <[email protected]>
Signed-off-by: Chris Abraham <[email protected]>
Signed-off-by: Chris Abraham <[email protected]>
Signed-off-by: James Hunt <[email protected]>
|
I've integrated the filter and results in to the /blog/ archive https://pr-890-cncfci.pantheonsite.io/blog/ Without featured/sticky post:
With featured/sticky post:
There is no need to have the /blog-filter page any more P.S. I think ACF released a security fix today, so that could likely be updated again |
Signed-off-by: James Hunt <[email protected]>
thetwopct
force-pushed
the
blog-filter
branch
from
8359999 to
32263c5
Compare
Signed-off-by: James Hunt <[email protected]>
Signed-off-by: James Hunt <[email protected]>
Signed-off-by: James Hunt <[email protected]>
Signed-off-by: Chris Abraham <[email protected]>
…sting Signed-off-by: Chris Abraham <[email protected]>
Signed-off-by: Chris Abraham <[email protected]>
Signed-off-by: Chris Abraham <[email protected]>
Signed-off-by: James Hunt <[email protected]>
Signed-off-by: Chris Abraham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue
PR instance
I've already created the Search/Filter called "Blog" on the live site and synched it with this dev instance. Currently it's set to infinite scroll but not sure if we should use pagination instead. The infinite scroll will need configuring to include the hr element which needs to be wrapped in a div with everything else.
This PR also upgrades plugins.
On Deploy: