-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync branch dev-tw from main(20231011) #2485
Conversation
Signed-off-by: dependabot[bot] <[email protected]>
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@seokho-son @jihoon-seo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ydFu Thank you for what you've been doing for this project!
I am leaving one approval of mine, and below is additional comment:
This PR seems to be not a merge blocker (or in other words, a conflict resolver) of merging dev-tw
into main
.
I think that we don't have to update the local branch frequently for small number of new commits (for the case of this PR, it is 1), provided that those commits are not crucial, urgent, or required.. 😅
(And of course, telling whether commits are crucial, urgent, or required might be subjective by person to person..)
Thank you for your review and reminder. I will try my best not to synchronize main to dev-tw with only one commit next time. The main reason for this change is that when dev-tw was first merged into the main branch, a necessary sub-task was to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Describe your changes
Initial merging the dev-tw branch into main branch
Task: Update dev-tw based on the latest main.
Related issue number or link (ex:
resolves #issue-number
)#2355
Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.