Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync branch dev-tw from main(20231011) #2485

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Sync branch dev-tw from main(20231011) #2485

merged 1 commit into from
Oct 16, 2023

Conversation

ydFu
Copy link
Collaborator

@ydFu ydFu commented Oct 11, 2023

Describe your changes

Initial merging the dev-tw branch into main branch
Task: Update dev-tw based on the latest main.

Related issue number or link (ex: resolves #issue-number)

#2355

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@netlify
Copy link

netlify bot commented Oct 11, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit a4d5b83
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/65263a43d84d58000867027c
😎 Deploy Preview https://deploy-preview-2485--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jihoon-seo jihoon-seo added maintainers Use this label if PR requires maintainers to take action lang/tw for Traditional Chinese labels Oct 11, 2023
@ydFu ydFu changed the title Sync branch dev-tw from main Sync branch dev-tw from main(20231011) Oct 11, 2023
@ydFu
Copy link
Collaborator Author

ydFu commented Oct 12, 2023

@seokho-son @jihoon-seo
This PR pertains to branch synchronization information. I kindly request your assistance in reviewing this PR, as my next milestone involves merging Traditional Chinese into the main branch and presenting it on the website.

Copy link
Collaborator

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ydFu Thank you for what you've been doing for this project!
I am leaving one approval of mine, and below is additional comment:
This PR seems to be not a merge blocker (or in other words, a conflict resolver) of merging dev-tw into main.
I think that we don't have to update the local branch frequently for small number of new commits (for the case of this PR, it is 1), provided that those commits are not crucial, urgent, or required.. 😅
(And of course, telling whether commits are crucial, urgent, or required might be subjective by person to person..)

@ydFu
Copy link
Collaborator Author

ydFu commented Oct 13, 2023

@ydFu Thank you for what you've been doing for this project! I am leaving one approval of mine, and below is additional comment: This PR seems to be not a merge blocker (or in other words, a conflict resolver) of merging dev-tw into main. I think that we don't have to update the local branch frequently for small number of new commits (for the case of this PR, it is 1), provided that those commits are not crucial, urgent, or required.. 😅 (And of course, telling whether commits are crucial, urgent, or required might be subjective by person to person..)

Thank you for your review and reminder. I will try my best not to synchronize main to dev-tw with only one commit next time.

The main reason for this change is that when dev-tw was first merged into the main branch, a necessary sub-task was to update dev-tw to the latest main, so this change was proposed.

Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seokho-son seokho-son merged commit c67a174 into dev-tw Oct 16, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/tw for Traditional Chinese maintainers Use this label if PR requires maintainers to take action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants