Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatcar governance review 2023-08-15 #467

Merged
merged 9 commits into from
Aug 31, 2023

Conversation

aliok
Copy link
Member

@aliok aliok commented Jul 21, 2023

Fixes #392

This is a governance review of Flatcar, with the snapshot of the main repository at commit 3e2ba40795 5e4331f233.

cc @jberkus @geekygirldawn

Notes:

  • governance/assessments/projects/flatcar/2023-08-15.md is the report path.
  • Since these reports might be referenced in other reports (future governance review reports, due diligence, etc), we might want to take our time and think if this is a good directory structure and a file name. Changing later might result in broken links.

@jberkus
Copy link
Contributor

jberkus commented Jul 21, 2023

/approve

Approved by me, now it goes to our TOC liaisons

@TheFoxAtWork @dzolotusky

@jberkus
Copy link
Contributor

jberkus commented Jul 21, 2023

@t-lo this is still a draft, but there's one must-fix in it, so I wanted you to see it as soon as possible so that you can create a couple PRs.

@aliok
Copy link
Member Author

aliok commented Jul 21, 2023

cc Flatcar maintainers, @miao0miao @t-lo

@aliok aliok changed the title Flatcar governance review 2022-07-07 Flatcar governance review 2023-07-07 Jul 21, 2023
@aliok aliok force-pushed the 2023-07-22-flatcar-governance-review branch from 3565ab1 to 889bdf6 Compare July 24, 2023 07:04
@t-lo
Copy link

t-lo commented Jul 24, 2023

Thank you foryour review and for calling this out!

To address the must-fix issue I filed PRs to the repos below. Listing these here for visibility / tracking.

The following repos do not have a code of conduct; please refer to the reasoning as to why. Please provide guidance on whether we should add a code of conduct nonetheless.

@aliok aliok force-pushed the 2023-07-22-flatcar-governance-review branch from 889bdf6 to c383bb1 Compare July 24, 2023 22:35
@t-lo
Copy link

t-lo commented Jul 25, 2023

@aliok @jberkus PRs for adding the CNCF code of conduct created and merged, thanks again for the ping! And huge thanks to @miao0miao, @tormath1 and @invidian for helping with the reviews!

Ali, Josh, could you please give feedback to the exceptions listed above? imho it doesn't make much sense to add a code of conduct there for the reasons stated.

@aliok
Copy link
Member Author

aliok commented Jul 28, 2023

@t-lo I am going to update the report based on your changes, before it gets merged.

@t-lo
Copy link

t-lo commented Jul 29, 2023

Thank you Ali, that's awesome!

@t-lo
Copy link

t-lo commented Jul 31, 2023

Please note that I'll be off for the next 3 weeks but @miao0miao and @vbatts will be around as points of contact for this time - please do not hesitate to involve them if you have any questions or concerns.

@aliok aliok force-pushed the 2023-07-22-flatcar-governance-review branch from c383bb1 to b75c2e7 Compare August 15, 2023 20:09
@aliok
Copy link
Member Author

aliok commented Aug 15, 2023

@jberkus @geekygirldawn
I've updated the governance review. See the latest commit f88f276

cc @t-lo @miao0miao @vbatts

@aliok aliok changed the title Flatcar governance review 2023-07-07 Flatcar governance review 2023-08-15 Aug 15, 2023
@aliok aliok force-pushed the 2023-07-22-flatcar-governance-review branch from 4f32e79 to 07dfdcb Compare August 16, 2023 21:57
@aliok
Copy link
Member Author

aliok commented Aug 18, 2023

We now wait for TOC liaisons' approval.

@TheFoxAtWork @dzolotusky

Copy link
Contributor

@TheFoxAtWork TheFoxAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great! Have the TOC sponsors for the project reviewed it?

Copy link

@dzolotusky dzolotusky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this done.

Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as TOC Sponsor for Flatcar.

Thanks @geekygirldawn, @jberkus and @aliok!

@mauilion
Copy link

LGTM as well

@aliok aliok force-pushed the 2023-07-22-flatcar-governance-review branch from f58a622 to d90bd0e Compare August 31, 2023 10:58
@aliok aliok enabled auto-merge August 31, 2023 10:58
@aliok aliok merged commit cc7aecd into cncf:main Aug 31, 2023
@aliok aliok deleted the 2023-07-22-flatcar-governance-review branch August 31, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

[Governance Review] Flatcar
8 participants