-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flatcar governance review 2023-08-15 #467
Conversation
/approve Approved by me, now it goes to our TOC liaisons |
@t-lo this is still a draft, but there's one must-fix in it, so I wanted you to see it as soon as possible so that you can create a couple PRs. |
cc Flatcar maintainers, @miao0miao @t-lo |
3565ab1
to
889bdf6
Compare
889bdf6
to
c383bb1
Compare
@aliok @jberkus PRs for adding the CNCF code of conduct created and merged, thanks again for the ping! And huge thanks to @miao0miao, @tormath1 and @invidian for helping with the reviews! Ali, Josh, could you please give feedback to the exceptions listed above? imho it doesn't make much sense to add a code of conduct there for the reasons stated. |
@t-lo I am going to update the report based on your changes, before it gets merged. |
Thank you Ali, that's awesome! |
Please note that I'll be off for the next 3 weeks but @miao0miao and @vbatts will be around as points of contact for this time - please do not hesitate to involve them if you have any questions or concerns. |
c383bb1
to
b75c2e7
Compare
@jberkus @geekygirldawn |
4f32e79
to
07dfdcb
Compare
We now wait for TOC liaisons' approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great! Have the TOC sponsors for the project reviewed it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as TOC Sponsor for Flatcar.
Thanks @geekygirldawn, @jberkus and @aliok!
LGTM as well |
Signed-off-by: Ali Ok <[email protected]>
Signed-off-by: Ali Ok <[email protected]>
Signed-off-by: Ali Ok <[email protected]>
Signed-off-by: Ali Ok <[email protected]>
Signed-off-by: Ali Ok <[email protected]>
Signed-off-by: Ali Ok <[email protected]>
Co-authored-by: Josh Berkus <[email protected]> Signed-off-by: Ali Ok <[email protected]>
Removed an unnecessary dot Signed-off-by: Ali Ok <[email protected]>
Signed-off-by: Ali Ok <[email protected]>
f58a622
to
d90bd0e
Compare
Fixes #392
This is a governance review of Flatcar, with the snapshot of the main repository at commit
3e2ba407955e4331f233.cc @jberkus @geekygirldawn
Notes:
governance/assessments/projects/flatcar/2023-08-15.md
is the report path.