Skip to content

Commit

Permalink
Correcting grammar to ensure the correct run of GitHub Actions
Browse files Browse the repository at this point in the history
  • Loading branch information
pedroignacio13 committed Dec 1, 2024
1 parent 5e1a39b commit c5cecf3
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 13 deletions.
18 changes: 9 additions & 9 deletions community/assessments/projects/openfga/joint-assessment.md
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ could have catastrophic consequences to the organization.
- malicious code protection is employed;
- component and OpenFGA app related events are monitored and detected;
- the correct configuration and operation of security features is tested and verified;
- information is checked for accuracy, completeness, validity, and authenticity. This is especially imporant in verifying and testing the model
- information is checked for accuracy, completeness, validity, and authenticity. This is especially important in verifying and testing the model
syntax and semantics
- Supply Chain Integrity and Attacks: How will risks related to OpenFGA itself, and its dependencies be assessed and tracked and remediated?
- Incident Response, Disaster Recovery, Continuity, SRE: How will use of OpenFGA affect existing plans for responding to, investigating, and remediating
Expand All @@ -409,18 +409,18 @@ could have catastrophic consequences to the organization.
- Malicious developers injecting malicious code or designs
- Developer/App Design Failures
- incorrect use of OpenFGA outside its intended design/goals
- incorrect confiuration of OpenFGA store, keys, certs, etc
- incorrect configuration of OpenFGA store, keys, certs, etc
- incorrect definition of app code using OpenFGA to check relationships, conditions
- incorrect or missing error handling code or corner cases
- logging or leaking sensitive information
- lack of stress and performance testing
- not using the latest secure releases
- OpenFGA/App Operations Failures
- failure to check the provenance and integrity of code used
- failure to check the provenance and integrity of confiuration used
- failure to check the provenance and integrity of configuration used
- failure to check the provenance and integrity of model(s) used
- failure to secure keys, OIDC TLS, or database encryption and access control and auditing
- failute to plan for continuity and disaster recovery
- failure to plan for continuity and disaster recovery
- failure to plan for security incident response
- OpenFGA API service unavailable at runtime, either failing in a secure closed way, or due to DoS attack
- Store database unavailable at runtime, either failing in a secure closed way, or due to DoS attack
Expand Down Expand Up @@ -450,7 +450,7 @@ should be considered outside the scope of this review.
Opportunities for improvement identified include:

- Implement FGA for server API
- Relook at user-defined API tokens as an authentication mechanism for API
- Re-look at user-defined API tokens as an authentication mechanism for API
- Make all installation scripts "secure by default"
- Validate best practices such as using strong API token and avoiding PII

Expand All @@ -464,7 +464,7 @@ tokens present several weak points that result in the findings below.
The project recommends oauth for secure authentication to the API. The recommendation
is to mark shared API tokens as a relatively insecure method of authentication and
that his be avoided in a production environment. This recommendation can be
updated both in the documentation as well as a WARNING can be emmitted in the logs
updated both in the documentation as well as a WARNING can be emitted in the logs
when authentication via shared API tokens is enabled.

The recommendation to enable Fine Grained Authorization for the API is being
Expand All @@ -479,14 +479,14 @@ and performing authorization on the proxy.
|Weakness|Env vars are accessible to anyone with access to the container. There cannot be further permissions set on these like files. Keys further give access to stores and models.|
|MITRE classification|TA0001: Initial Access -> T1078: Valid Accounts<br>TA0003: Persistence -> T1078: Valid Accounts<br>TA0004: Privilege Escalation -> T1078: Valid Accounts|
|Actors|openfga.server|
|Suggested Mitigation|Secrets mounted in filesystem can be restricted with permissions. Alternatively, <br>SPIFFE/ Spire integration may offer a much high level of security (specifically using x.509 SVIDs).|
|Suggested Mitigation|Secrets mounted in filesystem can be restricted with permissions. Alternatively, <br>SPIFFE/ Spire integration may offer a much high level of security (specifically using x.509 <!-- cSpell:ignore SVIDs -->).|
|Impact (High/ Med/ Low)|High|
|Likelihood (High/ Med/ Low)|Low|

|Summary|Authenticating with shared keys allows keys to be added to the list.|
|--|--|
|Discovered in self-assessment?|No|
|Weakness|Shared API keys are open to manipulation and bruteforcing since they are fixed keys.|
|Weakness|Shared API keys are open to manipulation and brute-forcing since they are fixed keys.|
|MITRE classification|TA0003: Persistence -> T1136: Create Account|
|Actors|openfga.server|
|Suggested Mitigation|Being able to manipulate keys in the container requires access to container. However, impact will be high as openfga access will allow attackers to assign themselves arbitrary privileges.<br>Mitigations include, the ability to rotate keys on a frequent basis and forcing these API tokens to be mounted as files (can be permission controlled) instead of environment variables. Don't use shared keys. Use OAuth or SPIFFE.|
Expand All @@ -507,7 +507,7 @@ and performing authorization on the proxy.
### Setting secure defaults for install

This section has findings related to default install options that can be made more
secure. The artifacts analysed in this section include the helm chart for installation
secure. The artifacts analyzed in this section include the helm chart for installation
and default configuration options.


Expand Down
7 changes: 3 additions & 4 deletions community/assessments/projects/spiffe-spire/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,14 @@ _Maturity_
(Examples)
- Known end-users include: Bloomberg, Bytedance, Pinterest, Square, Uber, and Yahoo Japan. This is not an exhaustive list as other organizations may use SPIFFE and SPIRE privately (due to the sensitivity surrounding exposure of security frameworks being used).
- SPIFFE and SPIRE are being used by numerous other companies, both large and small, to build higher layer products and services. This includes Decipher Technology Studios, F5 Networks, HashiCorp, Intel, Google, IBM, Tigera, VMware, and many others.
- The SPIFFE project has 5 owners from 5 different organizations.
- The SPIFFE project has 5 owners from 5 different organizations.
- The SPIRE project has 7 owners from 2 different organizations.


## Summary

**Design**: Covering many use cases of identity without exposing unnecesary complexity to the user, SPIFFE/SPIRE provide a streamlined and simple design to interact with. The SPIFFE '[Workload API](https://spiffe.io/spiffe/concepts/#spiffe-workload-api)' provides a great way for services and orchestration systems to integrate. This pluggable design for attestation, key management, databases, and more allows for easy extensibility.

**Analysis**: The project, as a security provider, has done due diligence in security and threat modeling. The security workflow is evident, and the project is in the correct direction to further improve its security process and CI verification.
**Analysis**: The project, as a security provider, has done due diligence in security and threat modeling. The security workflow is evident, and the project is in the correct direction to further improve its security process and CI verification.
The project fulfills a role below the orchestration framework layer, and for its effectiveness, consumers of identitiy bundles need to have a good understanding of the demarcation line of security responsibilities.

All questions from reviewers were addressed in [self-assessment](self-assessment.md)
Expand All @@ -39,7 +38,7 @@ with non-critical issues captured as issues and noted below.

### Recommendations to the project team

1. ([SPIFFE.IO-103](https://github.com/spiffe/spiffe.io/issues/103)) Make threat modelling materials accessible on the SPIFFE/SPIRE site and documents. There is a wealth of existing information on SPIFFE/SPIRE threat modeling which is not easy to find.
1. ([SPIFFE.IO-103](https://github.com/spiffe/spiffe.io/issues/103)) Make threat modelling materials accessible on the SPIFFE/SPIRE site and documents. There is a wealth of existing information on SPIFFE/SPIRE threat modeling which is not easy to find.

2. Expand security response team to include participants outside of Scytale.

Expand Down

0 comments on commit c5cecf3

Please sign in to comment.