Replacing RadClass.RadClass with RadClass.Processor #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stompsjo
force-pushed
the
rename-RadClass
branch
from
819043b to
3b022a0
Compare
|
@gonuke This PR is rebased and now ready for merge. |
Pull Request Test Coverage Report for Build 3363446292
💛 - Coveralls |
gonuke
approved these changes
Nov 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #38, the workflow of
RadClasswill slightly change.RadClass.RadClasswill now be seen predominantly as a data processing unit. While it does have functionality to conduct analysis iteratively as it processes data (seeAnalysisParameters, orRadClass.H0), the new SSML models will be used separately, after data processing occurs, acting upon the fully processed dataset.Since
RadClass.RadClass's scope has changed, I am renaming it to reflect its role:RadClass.Processor. Now, the output of the processor (i.e. processed data, or spectra) will be given to ML models as a post-processing step by the user.