test: Move from CDP to BiDi

See cockpit-project/cockpit#20832

Explicitly add a "glob" devDependency to follow suit with
cockpit-project/cockpit@680decc155a
It was previously used implicitly through a transient dependency of
something else, but our esbuild po-plugin uses it explicitly.

This causes some minor pixel test noise, adjust the references.

Makefile

@@ -41,7 +41,7 @@ COCKPIT_REPO_FILES = \
 	$(NULL)
 
 COCKPIT_REPO_URL = https://github.com/cockpit-project/cockpit.git
-COCKPIT_REPO_COMMIT = b5a98be3e0601b45cd8a557cde1c80b896a903fb # 322 + 19 commits
+COCKPIT_REPO_COMMIT = 83e1a5ac16d8eb8df60f90c8fa502a0d8bf21365 # 322 + 35 commits
 
 $(COCKPIT_REPO_FILES): $(COCKPIT_REPO_STAMP)
 COCKPIT_REPO_TREE = '$(strip $(COCKPIT_REPO_COMMIT))^{tree}'
@@ -127,12 +127,9 @@ devel-uninstall:
 print-version:
 	@echo "$(VERSION)"
 
-# required for running integration tests; commander and ws are deps of chrome-remote-interface
+# required for running integration tests
 TEST_NPMS = \
-	node_modules/chrome-remote-interface \
-	node_modules/commander \
 	node_modules/sizzle \
-	node_modules/ws \
 	$(NULL)
 
 dist: $(TARFILE)

package.json

@@ -17,7 +17,6 @@
   "devDependencies": {
     "argparse": "2.0.1",
     "buffer": "6.0.3",
-    "chrome-remote-interface": "0.33.2",
     "esbuild": "0.23.0",
     "esbuild-plugin-copy": "2.1.1",
     "esbuild-plugin-replace": "1.4.0",
@@ -33,6 +32,7 @@
     "eslint-plugin-react": "7.35.0",
     "eslint-plugin-react-hooks": "4.6.2",
     "gettext-parser": "8.0.0",
+    "glob": "11.0.0",
     "htmlparser": "1.7.7",
     "ipaddr.js": "2.2.0",
     "jed": "1.1.1",

test/browser/run-test.sh

@@ -14,7 +14,7 @@ if [ -e .git ]; then
     mv .git dot-git
 else
     # upstream tarballs ship test dependencies; print version for debugging
-    grep '"version"' node_modules/chrome-remote-interface/package.json
+    grep '"version"' node_modules/sizzle/package.json
 fi
 
 . /run/host/usr/lib/os-release

test/check-machines-networks

@@ -124,7 +124,7 @@ class TestMachinesNetworks(machineslib.VirtualMachinesCase):
         b.click(".pf-v5-c-card .pf-v5-c-card__header button:contains(Network)")
 
         # HACK: Firefox 112 on RHEL 8 does not have `:has` yet, so for now use JavaScript to obtain the elements parent sibling.
-        b.inject_js("""
+        b.eval_js("""
            ph_input_form_helper_text = function(id) {
               return document.getElementById(id).parentElement.parentElement.querySelector(".pf-v5-c-helper-text__item.pf-m-error").textContent
 

test/machineslib.py

@@ -442,7 +442,7 @@ def stop_all():
             self.allow_journal_messages(r".* couldn't get all properties of org.freedesktop.NetworkManager.Device at /org/freedesktop/NetworkManager/Devices/\d+: Timeout was reached")
 
         # avoid error noise about resources getting cleaned up
-        self.addCleanup(lambda: not self.browser.cdp.valid or self.browser.logout())
+        self.addCleanup(lambda: not self.browser.valid or self.browser.logout())
 
         # noVNC warns about this for non-TLS connections; for RHEL downstream testing
         self.allow_browser_errors("noVNC requires a secure context")
@@ -505,7 +505,7 @@ def downloadVmsArtifacts(self):
 
     def tearDown(self):
         b = self.browser
-        if b.cdp.valid and b.is_present("#button.alert-link.more-button"):
+        if b.valid and b.is_present("#button.alert-link.more-button"):
             b.click("button.alert-link.more-button")
 
         if self.getError():