Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spacing between the items inside the resource status label #1259

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

KKoukiou
Copy link
Collaborator

@KKoukiou KKoukiou commented Oct 13, 2023

Fixes #1111

@martinpitt
Copy link
Member

Sorry, this fell through the cracks. I rebased this, fixed the conflict, and restricted the pixel test to the particular VM table row instead of the whole page -- otherwise this is too brittle to unrelated changes.

There were previously two other pixel changes which are likely related to the first commit. I'll mop them up after the next run if necessary.

Thanks!

@martinpitt
Copy link
Member

This pixel change is legit, picking it up.

Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Epharisto!

@martinpitt martinpitt merged commit adb7a64 into cockpit-project:main Nov 13, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Machine error state looks strange
3 participants