Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add some checks about the source of NICs #1326

Merged
merged 1 commit into from
Nov 30, 2023
Merged

test: add some checks about the source of NICs #1326

merged 1 commit into from
Nov 30, 2023

Conversation

yunmingyang
Copy link
Contributor

No description provided.

@martinpitt
Copy link
Member

The testVmNICs test failed, but at first sight that shouldn't be due to your changes. Retrying.

@jelly
Copy link
Member

jelly commented Nov 30, 2023

The testVmNICs test failed, but at first sight that shouldn't be due to your changes. Retrying.

iirc this has been a flake for a while?

martinpitt
martinpitt approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinpitt martinpitt merged commit 29d4565 into cockpit-project:main Nov 30, 2023
14 checks passed
@yunmingyang yunmingyang deleted the extraChecksAboutTap branch November 30, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinpitt martinpitt martinpitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yunmingyang @martinpitt @jelly