Revert "test: handle duplicate id's in PF modal dialogs" #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 15672fd. patternfly/patternfly-react#9399 was fixed in PatternFly 5.1.1, which we depend on.
|
Totally not important.. I was just grepping test/ for |
jelly
approved these changes
Nov 28, 2023
jelly
added a commit
to jelly/cockpit
that referenced
this pull request
Sep 5, 2024
This was fixed in PatternFly already and in machines. cockpit-project/cockpit-machines#1330 Related: cockpit-project#20973
jelly
added a commit
to jelly/cockpit
that referenced
this pull request
Sep 10, 2024
This was fixed in PatternFly already and in machines. cockpit-project/cockpit-machines#1330 Related: cockpit-project#20973
jelly
added a commit
to cockpit-project/cockpit
that referenced
this pull request
Sep 10, 2024
This was fixed in PatternFly already and in machines. cockpit-project/cockpit-machines#1330 Related: #20973
cowboyox
pushed a commit
to cowboyox/cockpit
that referenced
this pull request
Oct 8, 2024
This was fixed in PatternFly already and in machines. cockpit-project/cockpit-machines#1330 Related: #20973
SludgeGirl
pushed a commit
to Nykseli/cockpit
that referenced
this pull request
Nov 12, 2024
This was fixed in PatternFly already and in machines. cockpit-project/cockpit-machines#1330 Related: cockpit-project#20973
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 15672fd.
patternfly/patternfly-react#9399 was fixed in PatternFly 5.1.1, which we depend on.