Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consoles: Also wait for address when connecting to VNC #2005

Merged
merged 1 commit into from
Jan 27, 2025
Merged

consoles: Also wait for address when connecting to VNC #2005

merged 1 commit into from
Jan 27, 2025

Conversation

mvollmer
Copy link
Member

If the inactive XML config contains a port but not a address, we would try to connect too early, before the address was actually filled in.

@mvollmer
consoles: Also wait for address when connecting to VNC
56a9177 
If the inactive XML config contains a port but not a address, we would
try to connect too early, before the address was actually filled in.
@mvollmer mvollmer requested a review from jelly January 27, 2025 10:34
@martinpitt
Copy link
Member

The failures look like flakes, retrying.

martinpitt
martinpitt approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinpitt martinpitt merged commit b598898 into cockpit-project:main Jan 27, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinpitt martinpitt martinpitt approved these changes

@jelly jelly Awaiting requested review from jelly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvollmer @martinpitt