consoles: Fix constant VNC reconnections when there is a password #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We would pass a new object to VncConsole.credentials on every render, which would trigger it to re-connect to the VNC server every time. This shows up as flicker in the UI, and will also eventually break the connection entirely, somehow.
mvollmer
force-pushed
the
consoles-fix-reconnects
branch
from
1eb0306 to
241383e
Compare
martinpitt
approved these changes
Feb 5, 2025
It's a use case for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would pass a new object to VncConsole.credentials on every render, which would trigger it to re-connect to the VNC server every time. This shows up as flicker in the UI, and will also eventually break the connection entirely, somehow.