-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
139698: catalog/lease: optimize WaitForInitialVersion for multiple objects r=fqazi a=fqazi Previously, the WaitForInitialVersion serially went over objects one at time, which was sub-optimal. This meant that a lot of round trips were required to wait when a large number of objects were generated within a single txn. To address this, this patch changes WaitForInitialVersion to iterate on a per-schema basis and to be able to combine waits for multiple descriptors. This patch also adds extra testing for concurrent WaitForInitalVersion calls ``` benchdiff with these changes: name old time/op new time/op delta GenerateObjects/10000_tables-10 5.83s ± 1% 0.73s ± 2% -87.51% (p=0.000 n=8+9) GenerateObjects/1000_tables-10 517ms ± 3% 76ms ± 3% -85.39% (p=0.000 n=9+10) GenerateObjects/10x100_tables-10 519ms ± 3% 89ms ± 1% -82.85% (p=0.000 n=10+10) GenerateObjects/10x10x10_tables-10 572ms ± 7% 170ms ± 3% -70.26% (p=0.000 n=9+9) name old alloc/op new alloc/op delta GenerateObjects/10000_tables-10 6.24GB ± 2% 1.24GB ±10% -80.20% (p=0.000 n=8+10) GenerateObjects/1000_tables-10 343MB ± 1% 116MB ± 0% -66.09% (p=0.000 n=9+10) GenerateObjects/10x100_tables-10 344MB ± 0% 130MB ± 1% -62.25% (p=0.000 n=8+10) GenerateObjects/10x10x10_tables-10 365MB ± 0% 175MB ± 1% -52.21% (p=0.000 n=8+10) name old allocs/op new allocs/op delta GenerateObjects/10000_tables-10 38.5M ± 4% 6.5M ±15% -83.04% (p=0.000 n=9+10) GenerateObjects/1000_tables-10 2.06M ± 0% 0.60M ± 0% -70.87% (p=0.000 n=8+10) ``` Fixes: #139495 Release note: None 139715: cli/pgx: Update pgx versions in go.mod r=spilchen a=spilchen This commit updates the versions of specific packages from the github.com/jackc repository in go.mod to address known security vulnerabilities. The updated versions include fixes for these vulnerabilities. Notably, the signature of the Encode() function in the pgx library has changed. It now returns both the encoded message and an error. Most of the changes in this commit are updates to handle the new function signature appropriately. Epic: none Release note: none Informs #137595 139736: workload/schemachanger: limit size of datums during insert r=fqazi a=fqazi Previously, the insert statement in the randomized schema changer workload could have unbounded sizes for individual datums. This patch adds size limit for datums in the insert operation, where datums will be regenerated a limited number of times until they are below a maximum size. Fixes: #139494 Release note: None Co-authored-by: Faizan Qazi <[email protected]> Co-authored-by: Matt Spilchen <[email protected]>
- Loading branch information
Showing
22 changed files
with
432 additions
and
218 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5155,10 +5155,10 @@ def go_deps(): | |
| name = "com_github_jackc_pgconn", | ||
| build_file_proto_mode = "disable_global", | ||
| importpath = "github.com/jackc/pgconn", | ||
| sha256 = "d7935c04e5ee85f2dcab090692d2c24008071865a3af3581580bcc331a8f41d5", | ||
| strip_prefix = "github.com/jackc/[email protected].0", | ||
| sha256 = "164dbb661090368062498701530fcb1f62d6acc06558859646b62d97128ac06f", | ||
| strip_prefix = "github.com/jackc/[email protected].3", | ||
| urls = [ | ||
| "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/jackc/pgconn/com_github_jackc_pgconn-v1.14.0.zip", | ||
| "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/jackc/pgconn/com_github_jackc_pgconn-v1.14.3.zip", | ||
| ], | ||
| ) | ||
| go_repository( | ||
|
|
@@ -5205,10 +5205,10 @@ def go_deps(): | |
| name = "com_github_jackc_pgproto3_v2", | ||
| build_file_proto_mode = "disable_global", | ||
| importpath = "github.com/jackc/pgproto3/v2", | ||
| sha256 = "e6bafa5c3522534557a818f56939dde7b496c6669a5db9a74a0c91ab5290612c", | ||
| strip_prefix = "github.com/jackc/pgproto3/[email protected].2", | ||
| sha256 = "53ea236cbfe241693b439092e2d51b404c2a635ee3fe64ea7aad1527cb715189", | ||
| strip_prefix = "github.com/jackc/pgproto3/[email protected].3", | ||
| urls = [ | ||
| "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/jackc/pgproto3/v2/com_github_jackc_pgproto3_v2-v2.3.2.zip", | ||
| "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/jackc/pgproto3/v2/com_github_jackc_pgproto3_v2-v2.3.3.zip", | ||
| ], | ||
| ) | ||
| go_repository( | ||
|
|
@@ -5225,10 +5225,10 @@ def go_deps(): | |
| name = "com_github_jackc_pgtype", | ||
| build_file_proto_mode = "disable_global", | ||
| importpath = "github.com/jackc/pgtype", | ||
| sha256 = "7e67f5b944cbd401025c6473e624ef61ed196e3ed0f77ed437b0621cf820c0c9", | ||
| strip_prefix = "github.com/jackc/[email protected].0", | ||
| sha256 = "3acb69a66e7e432c010d503425810620d04c304166c45083fa8a96feca13054d", | ||
| strip_prefix = "github.com/jackc/[email protected].1", | ||
| urls = [ | ||
| "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/jackc/pgtype/com_github_jackc_pgtype-v1.14.0.zip", | ||
| "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/jackc/pgtype/com_github_jackc_pgtype-v1.14.1.zip", | ||
| ], | ||
| ) | ||
| go_repository( | ||
|
|
@@ -5245,10 +5245,10 @@ def go_deps(): | |
| name = "com_github_jackc_pgx_v5", | ||
| build_file_proto_mode = "disable_global", | ||
| importpath = "github.com/jackc/pgx/v5", | ||
| sha256 = "198eebac7e875b51616090fe2e3694e6f27e335afcc3c47ae9991497ade7f52a", | ||
| strip_prefix = "github.com/jackc/pgx/v5@v5.4.2", | ||
| sha256 = "003bc28d696865bd7cb2819d3902c0415bee4d276b129f92a8438330e6619f4d", | ||
| strip_prefix = "github.com/jackc/pgx/v5@v5.5.4", | ||
| urls = [ | ||
| "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/jackc/pgx/v5/com_github_jackc_pgx_v5-v5.4.2.zip", | ||
| "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/jackc/pgx/v5/com_github_jackc_pgx_v5-v5.5.4.zip", | ||
| ], | ||
| ) | ||
| go_repository( | ||
|
|
@@ -5265,10 +5265,10 @@ def go_deps(): | |
| name = "com_github_jackc_puddle_v2", | ||
| build_file_proto_mode = "disable_global", | ||
| importpath = "github.com/jackc/puddle/v2", | ||
| sha256 = "b99ea95df0c0298caf2be786c9eba511bfde2046eccfaa06e89b3e460ab406b0", | ||
| strip_prefix = "github.com/jackc/puddle/[email protected].0", | ||
| sha256 = "6698895617fabb929fa1ac868ad5253e02a997888bf5c6004379c5b29eedee58", | ||
| strip_prefix = "github.com/jackc/puddle/[email protected].1", | ||
| urls = [ | ||
| "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/jackc/puddle/v2/com_github_jackc_puddle_v2-v2.2.0.zip", | ||
| "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/jackc/puddle/v2/com_github_jackc_puddle_v2-v2.2.1.zip", | ||
| ], | ||
| ) | ||
| go_repository( | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.