Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.3: workload/schemachanger: limit size of datums during insert #139782

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jan 24, 2025

Backport 1/1 commits from #139736 on behalf of @fqazi.

/cc @cockroachdb/release


Previously, the insert statement in the randomized schema changer workload could have unbounded sizes for individual datums. This patch adds size limit for datums in the insert operation, where datums will be regenerated a limited number of times until they are below a maximum size.

Fixes: #139494

Release note: None


Release justification: test only change

Previously, the insert statement in the randomized schema changer
workload could have unbounded sizes for individual datums. This patch
adds size limit for datums in the insert operation, where datums will be
regenerated a limited number of times until they are below a maximum
size.

Fixes: #139494

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner January 24, 2025 21:42
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.3-139736 branch from a6031e0 to 76ca7a9 Compare January 24, 2025 21:42
@blathers-crl blathers-crl bot requested review from herkolategan and removed request for a team January 24, 2025 21:42
@blathers-crl blathers-crl bot added the blathers-backport This is a backport that Blathers created automatically. label Jan 24, 2025
@blathers-crl blathers-crl bot requested a review from DarrylWong January 24, 2025 21:42
@blathers-crl blathers-crl bot added the O-robot Originated from a bot. label Jan 24, 2025
Copy link
Author

blathers-crl bot commented Jan 24, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Jan 24, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss merged commit 6ade689 into release-24.3 Jan 24, 2025
20 of 21 checks passed
@rafiss rafiss deleted the blathers/backport-release-24.3-139736 branch January 24, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants