dev: add extra startup flag to fix breakage on Darwin/ARM64 machines #139797
+16
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
rickystewart
force-pushed
the
arm64-darwin-fix
branch
from
fed7610 to
35ad643
Compare
When cross-building, Java can crash on Darwin/ARM64 machines due to an error that looks like this: ``` A fatal error has been detected by the Java Runtime Environment: SIGILL (0x4) at pc=0x0000ffffadf3fc1c, pid=39, tid=40 ``` This was addressed in cockroachdb#139670, which adds a startup flag to disable the use of SVE. Unfortunately this broke the build on x86-64 machines (cockroachdb#139756). So now we must apply the flag conditionally only where relevant. Closes: cockroachdb#139756 Epic: none Release note: None
rickystewart
force-pushed
the
arm64-darwin-fix
branch
from
35ad643 to
56a07da
Compare
rail
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cross-building, Java can crash on Darwin/ARM64 machines due to an error that looks like this:
This was addressed in #139670, which adds a startup flag to disable the use of SVE. Unfortunately this broke the build on x86-64 machines (#139756). So now we must apply the flag conditionally only where relevant.
Closes: #139756
Epic: none
Release note: None