Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new player_quality 'disabled' option #2280

Merged
merged 2 commits into from
May 17, 2024
Merged

add new player_quality 'disabled' option #2280

merged 2 commits into from
May 17, 2024

Conversation

raszpl
Copy link
Contributor

@raszpl raszpl commented May 17, 2024

fixes #2273

@raszpl raszpl marked this pull request as ready for review May 17, 2024 02:23
@ImprovedTube ImprovedTube merged commit f5e0ec4 into code-charity:master May 17, 2024
@ImprovedTube
Copy link
Member

ImprovedTube commented May 17, 2024

hi! @raszpl if auto equaled "do nothing", before and is now an option, then we need to migrate people from auto to disabled via background.js...?

@raszpl raszpl deleted the patch-5 branch May 17, 2024 03:25
@raszpl
Copy link
Contributor Author

raszpl commented May 17, 2024

Yes, good point.

ImprovedTube added a commit that referenced this pull request May 17, 2024
@raszpl
Copy link
Contributor Author

raszpl commented May 17, 2024

but not like that :-)
all you need is delete player_quality when it was previously set to auto, player_quality_auto doesnt have to be touched, it already filters out Auto as that doesnt make sense for off focus setting.

all is needed here is

		chrome.storage.local.get('player_quality', function (result) {
			if (result.player_quality === 'auto') {
				chrome.storage.local.remove(['player_quality']);
			}
		});

@ImprovedTube
Copy link
Member

player_quality_auto is a new key to tell if auto was removed once already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The manually selected quality is no longer respected when the extension's quality is set to 'Auto'
2 participants