Edit: Defining forbidFocus() once in advance, instead of inside features

[4yman-0]

Fix #2754

ImprovedTube.chapters tries to call ImprovedTube.forbidFocus which does not exists or is not a function. Tested with Chromium on Arch Linux and random youtube videos.

[ImprovedTube]

thank you! @4yman-0 glad you are here! sorry this one seems to be a duplicate of #2750

[ImprovedTube]

hi @4yman-0, i appreciated your thoughts in the code.
the bug #2754 was undone in #2750.

While defining a function for every user in every YouTube-tab is cheap,
i wanted to make it conditional (it just appears in 3 features yet.)
So i had defined it conditionally in functions.js:

if (document.documentElement.dataset.pageType === 'video'
	 && (ImprovedTube.storage.description === "expanded" || ImprovedTube.storage.transcript === true || ImprovedTube.storage.chapters === true )) { ImprovedTube.forbidFocus =  function (ms) }

however i undid this to undo the bug

if you like, we should check why, going back to Dec21, https://github.com/code-charity/youtube/tree/HEAD@%7B2024-12-21%7D, typos? timing?/#2415

[4yman-0]

So i defined it conditionally in functions.js:

if (document.documentElement.dataset.pageType === 'video'
	 && (ImprovedTube.storage.description === "expanded" || ImprovedTube.storage.transcript === true || ImprovedTube.storage.chapters === true )) { ImprovedTube.forbidFocus =  function (ms) }

I'll close the pull request if that's the case :)

[ImprovedTube]

hi! :) if or when? you chose, i'm fine if this thread keeps evolving - or to hoard open PRs for decades

Or i can merge for our motivation (and remove the function from the other two features where it appears)

[ImprovedTube]

Great team-work! 👍🎉

[4yman-0]

This PR sets forbidFocus initialy while your commits make improvedTube.chapters set forbidFocus every time it is called.

Can you review?

[ImprovedTube]

we should check why, going back to Dec21, https://github.com/code-charity/youtube/tree/HEAD@%7B2024-12-21%7D, typos? timing?/#2415

/why the now out-commented condition might not yet work at that point in the code

[4yman-0]

Looks Good To Me!