Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: validation errors not showing correctly if both email and password are invalid. #1714

Open
ToseebNadaf opened this issue Jan 15, 2025 · 2 comments · May be fixed by #1715
Open

bug: validation errors not showing correctly if both email and password are invalid. #1714

ToseebNadaf opened this issue Jan 15, 2025 · 2 comments · May be fixed by #1715
Labels
bug Something isn't working

Comments

@ToseebNadaf
Copy link

Describe the bug
Validation errors for both email and password are not displayed correctly when both fields are invalid, making it unclear to the user which field needs attention.

To Reproduce

  1. Enter an invalid email (e.g., "invalidemail") and an invalid password (e.g., "123").
  2. Click the "Sign In" button.
  3. The validation errors for both fields don't show up correctly.

Expected behavior
Both email and password validation errors should be displayed clearly, indicating what needs to be corrected, e.g., "Invalid email format" and "Password must be at least 6 characters long.

Video

error_before.mp4
@ToseebNadaf ToseebNadaf added the bug Something isn't working label Jan 15, 2025
@ToseebNadaf ToseebNadaf linked a pull request Jan 15, 2025 that will close this issue
Open
@AdvaithMahendrakar12
Copy link

AdvaithMahendrakar12 commented Jan 21, 2025 •
edited
Loading

Hello is this Issue fixed?Want to contribute

@ToseebNadaf
Copy link
Author

ToseebNadaf commented Jan 21, 2025 •
edited
Loading

@AdvaithMahendrakar12 I have already raised PR for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: display validation errors correctly for both email and password when invalid ToseebNadaf/cms
2 participants
@ToseebNadaf @AdvaithMahendrakar12