New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: display validation errors correctly for both email and password when invalid #1715

Open

ToseebNadaf wants to merge 3 commits into code100x:main from ToseebNadaf:bug/signin_validation_issue

+397 −128

ToseebNadaf commented Jan 15, 2025 •

edited

Loading

PR Fixes:

Added Zod validation for email and password.
Replaced useRef with useState for better state management.
Memoized handleEmailChange with useCallback to prevent unnecessary re-renders.
Implemented client-side form validation before sign-in attempt.
Mapped error responses to display meaningful error messages.

Resolves #1714

Checklist before requesting a review

[✅] I have performed a self-review of my code
[✅] I assure there is no similar/duplicate pull request regarding same issue

Before -->

error_before.mp4

After -->

cursorful-video-1736974544915_2_2.mp4

ToseebNadaf added 3 commits

January 15, 2025 22:56


          feat: Create contact form to report issues and integrate Nodemailer f…

8209d6b

…or email notifications


          Added missing authentication check

42ac2b3


          Fix: Display validation errors correctly for both email and password …

…when invalid

Author

ToseebNadaf commented Jan 16, 2025

@devsargam suggest any changes if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet